fix: #168 TextFrame.fit_text() method crashing on long words#416
Open
jackson-ml wants to merge 2 commits into
Open
fix: #168 TextFrame.fit_text() method crashing on long words#416jackson-ml wants to merge 2 commits into
jackson-ml wants to merge 2 commits into
Conversation
added 2 commits
August 1, 2018 11:29
… a word that would not be able to fit within a single line at the full font size.
also fixed a bug putting a space at the start of a line.
jackson-ml
changed the title
jackson-ml
changed the title
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextFrame.fit_text() currently crashes when the text contains a word that would be longer than the width of the shape at full point size, as it is unable to produce an acceptable line break. Powerpoint is willing to simply line break in the middle of the word in this case, so this imitates that behavior.
Fixes #168.